ahmedabu98 commented on code in PR #31608:
URL: https://github.com/apache/beam/pull/31608#discussion_r1760968604
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PreparePubsubWriteDoFn.java:
##########
@@ -193,16 +190,6 @@ public void process(
.add("pubsub", "topic",
PubsubClient.topicPathFromPath(topic).getDataCatalogSegments());
reportedLineage = topic;
}
- // TODO: Remove this check once Dataflow's native sink supports ordering
keys.
- if (!allowOrderingKey && !Strings.isNullOrEmpty(message.getOrderingKey()))
{
Review Comment:
What do you think is a good cadence here? Once per bundle may be too
frequent for streaming (where I heard bundles can be very small).
Maybe once per DoFn? It would be logged across multiple threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
