sjvanrossum commented on code in PR #31608:
URL: https://github.com/apache/beam/pull/31608#discussion_r1759694823
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PreparePubsubWriteDoFn.java:
##########
@@ -175,6 +193,16 @@ public void process(
.add("pubsub", "topic",
PubsubClient.topicPathFromPath(topic).getDataCatalogSegments());
reportedLineage = topic;
}
+ // TODO: Remove this check once Dataflow's native sink supports ordering
keys.
Review Comment:
Seems good to me. My intention with being more strict about this was to
prevent user confusion or potential data loss in case the ordering key can't be
reconstructed from the message, but that disregards how the transform may be
used today.
Adding this check would force users to scrub messages before output which I
now realize does not look elegant in the flow of a pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
