reuvenlax commented on code in PR #32757:
URL: https://github.com/apache/beam/pull/32757#discussion_r1799811464
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java:
##########
@@ -125,18 +126,20 @@ public static FieldValueTypeInformation forOneOf(
.build();
}
- public static FieldValueTypeInformation forField(Field field, int index) {
- TypeDescriptor<?> type = TypeDescriptor.of(field.getGenericType());
+ public static FieldValueTypeInformation forField(
+ Field field, int index, Map<Type, Type> boundTypes) {
Review Comment:
In this case, I think so. This is a logically an internal class, which was
only marked public because we needed to access it from other packages (e.g. the
protobuf package). The fact that it was not marked @Internal was likely a
mistake, and I think it's fine to change it in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
