reuvenlax commented on code in PR #32757:
URL: https://github.com/apache/beam/pull/32757#discussion_r1799845653
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/POJOUtils.java:
##########
@@ -73,8 +73,11 @@
public class POJOUtils {
public static Schema schemaFromPojoClass(
- TypeDescriptor<?> typeDescriptor, FieldValueTypeSupplier
fieldValueTypeSupplier) {
- return StaticSchemaInference.schemaFromClass(typeDescriptor,
fieldValueTypeSupplier);
+ TypeDescriptor<?> typeDescriptor,
+ FieldValueTypeSupplier fieldValueTypeSupplier,
+ Map<Type, Type> boundTypes) {
Review Comment:
Added Internal annotation. This was never meant to be used outside of Beam
internals.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/JavaBeanUtils.java:
##########
@@ -64,8 +65,11 @@
public class JavaBeanUtils {
/** Create a {@link Schema} for a Java Bean class. */
public static Schema schemaFromJavaBeanClass(
- TypeDescriptor<?> typeDescriptor, FieldValueTypeSupplier
fieldValueTypeSupplier) {
- return StaticSchemaInference.schemaFromClass(typeDescriptor,
fieldValueTypeSupplier);
+ TypeDescriptor<?> typeDescriptor,
+ FieldValueTypeSupplier fieldValueTypeSupplier,
+ Map<Type, Type> boundTypes) {
Review Comment:
Ditto - added Internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
