kennknowles commented on PR #32757: URL: https://github.com/apache/beam/pull/32757#issuecomment-2419524340
> The fix has been submitted - is that Yaml test still failing? Separately we should figure out why none of those tests triggered on my initial PR :( > […](#) > On Wed, Oct 16, 2024 at 6:00 PM Kenn Knowles ***@***.***> wrote: Suspected culprit of breaking this one too https://github.com/apache/beam/actions/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml?query=branch%3Amaster+is%3Acompleted — Reply to this email directly, view it on GitHub <[#32757 (comment)](https://github.com/apache/beam/pull/32757#issuecomment-2418271581)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAYJVJWYRWOHOV74QY6PS3Z34D4HAVCNFSM6AAAAABPZOTUP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGI3TCNJYGE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***> Yea we could see if there is a natural precommit trigger that would make sense. It may be that these are far enough apart in the codebase that postcommit is where we expect to catch it anyhow. Then we would roll back and roll forward touching a trigger file in `.github/trigger_files` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
