chamikaramj commented on PR #31486: URL: https://github.com/apache/beam/pull/31486#issuecomment-2450973612
Based on an offline discussion, we should do the forking to select the correct write transforms at a single 'BigQueryWriteSchemaWriteTransformProvider' instead of expecting the caller to perform the expansion for the exact implementation. The pipeline options needed for this (for example, ```dataflowServiceOptions=streaming_mode_at_least_once```) should be provided to this call (accessible via ```input.getPipeline().getOptions()```). Also, we can use ```input.get(INPUT_ROWS_TAG).isBounded()``` to determine whether this is an unbounded call or not. This should be possible since all BQ write schema-transforms here share the same configuration. May be we should keep read general in a similar manner to support future expansions / read methods. cc: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
