ahmedabu98 commented on code in PR #31486:
URL: https://github.com/apache/beam/pull/31486#discussion_r1831659789
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedTransformConstants.java:
##########
@@ -50,9 +50,27 @@ public class ManagedTransformConstants {
private static final Map<String, String> KAFKA_WRITE_MAPPINGS =
ImmutableMap.<String, String>builder().put("data_format",
"format").build();
+ private static final Map<String, String> BIGQUERY_READ_MAPPINGS =
+ ImmutableMap.<String, String>builder()
+ .put("table", "table_spec")
+ .put("fields", "selected_fields")
+ .build();
+
+ private static final Map<String, String> BIGQUERY_WRITE_MAPPINGS =
+ ImmutableMap.<String, String>builder()
+ .put("at_least_once", "use_at_least_once_semantics")
Review Comment:
Yep this essential is mapped to parameters in the schematransform
configuration. And in this PR, we are consolidating the file loads and storage
api configurations into one
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java:
##########
@@ -124,7 +129,9 @@ public static ManagedTransform read(String source) {
* managed sinks are:
*
* <ul>
- * <li>{@link Managed#ICEBERG} : Write to Apache Iceberg
+ * <li>{@link Managed#ICEBERG} : Write to Apache Iceberg tables
+ * <li>{@link Managed#KAFKA} : Write to Apache Kafka topics
+ * <li>{@link Managed#BIGQUERY} : Write to GCP BigQuery tables
Review Comment:
This sounds like implementation detail -- does the user need to know this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
