dennisylyung commented on a change in pull request #12583:
URL: https://github.com/apache/beam/pull/12583#discussion_r480253111
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/dynamodb/DynamoDBIOTest.java
##########
@@ -199,7 +209,8 @@ public void testRetries() throws Throwable {
writeRequest -> KV.of(tableName, writeRequest))
.withRetryConfiguration(
DynamoDBIO.RetryConfiguration.create(4,
Duration.standardSeconds(10)))
-
.withAwsClientsProvider(AwsClientsProviderMock.of(amazonDynamoDBMock)));
+
.withAwsClientsProvider(AwsClientsProviderMock.of(amazonDynamoDBMock))
+ .withOverwriteByPKeys(overwriteByPKeys));
Review comment:
Spent some time working on this but couldn't come up with anything. Any
tips how to test if the batches are correct? I can't think of anyway to test it
in a pipeline, as the end result written to the db is the same (the issue is on
api level). Should I do it outside a pipeline, call processElement manually and
check the batch size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
