apilloud commented on a change in pull request #12389:
URL: https://github.com/apache/beam/pull/12389#discussion_r470743118
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java
##########
@@ -443,6 +467,17 @@ public static TableRow toTableRow(Row row) {
}
return convertedItems;
+ case MAP:
+ Map<?, ?> pairs = (Map<?, ?>) fieldValue;
+ convertedItems = Lists.newArrayListWithCapacity(pairs.size());
+ for (Map.Entry<?, ?> pair : pairs.entrySet()) {
+ convertedItems.add(
+ new TableRow()
+ .set(BIGQUERY_MAP_KEY_FIELD_NAME, pair.getKey())
Review comment:
You'll need to convert the types stored in the map as well. Something
like `fromBeamField(fieldType.getMapKeyType(), pair.getKey())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
