Abacn commented on code in PR #33231:
URL: https://github.com/apache/beam/pull/33231#discussion_r1899637758
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -539,4 +560,151 @@ public void testAtLeastOnceWithIgnoreUnknownValues()
throws Exception {
public void testAtLeastOnceWithAutoSchemaUpdate() throws Exception {
runStreamingPipelineWithSchemaChange(Write.Method.STORAGE_API_AT_LEAST_ONCE,
true, true);
}
+
+ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean
useAtLeastOnce) throws Exception {
Review Comment:
are these new tests intended to run on direct runner (GCP IO PreCommit) or
also on Dataflow (Dataflow Runner v1/v2 PostCommit) suite? If the latter,
please trigger a PostCommit job to check if the test setting works on a remote
runner. If the former, add these tests in the exclusion test in
https://github.com/apache/beam/blob/97c4134bfc311093e947abde68eddcd51fce375b/runners/google-cloud-dataflow-java/build.gradle#L631
and
https://github.com/apache/beam/blob/97c4134bfc311093e947abde68eddcd51fce375b/runners/google-cloud-dataflow-java/build.gradle#L682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
