ahmedabu98 commented on code in PR #33231:
URL: https://github.com/apache/beam/pull/33231#discussion_r1890565577


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -531,6 +532,30 @@ public void process(
                       element.getKey().getKey(), dynamicDestinations, 
datasetService);
               tableSchema = converter.getTableSchema();
               descriptor = converter.getDescriptor(false);
+
+              if (autoUpdateSchema) {

Review Comment:
   Also note that the updated schema is ignored when the **StreamWriter 
object's** creation time is later than the updated schema's. 
   i.e. it doesn't matter when the WriteStream itself was created



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to