Naireen commented on code in PR #33408:
URL: https://github.com/apache/beam/pull/33408#discussion_r1909343906
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaSinkMetrics.java:
##########
@@ -40,6 +42,7 @@ public class KafkaSinkMetrics {
// Base Metric names
private static final String RPC_LATENCY = "RpcLatency";
+ private static final String ESTIAMTED_BACKLOG_SIZE = "EstimatedBacklogSize";
Review Comment:
Done
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaSinkMetrics.java:
##########
@@ -71,6 +75,48 @@ public static Histogram createRPCLatencyHistogram(RpcMethod
method, String topic
return new DelegatingHistogram(metricName, buckets, false, true);
}
+ /**
+ * Creates an Gauge metric to record per partition backlog. Metric will have
name:
Review Comment:
Thanks, updated the working for the histogram metric above as well to be
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
