Naireen commented on code in PR #33408:
URL: https://github.com/apache/beam/pull/33408#discussion_r1920529274
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaMetrics.java:
##########
@@ -67,15 +74,22 @@ abstract class KafkaMetricsImpl implements KafkaMetrics {
private static final Logger LOG =
LoggerFactory.getLogger(KafkaMetricsImpl.class);
- static HashMap<String, Histogram> latencyHistograms = new HashMap<String,
Histogram>();
+ static ConcurrentHashMap<String, Histogram> latencyHistograms =
+ new ConcurrentHashMap<String, Histogram>();
+
+ abstract ConcurrentHashMap<String, ConcurrentLinkedQueue<Duration>>
perTopicRpcLatencies();
- abstract HashMap<String, ConcurrentLinkedQueue<Duration>>
perTopicRpcLatencies();
+ static ConcurrentHashMap<String, Gauge> backlogGauges = new
ConcurrentHashMap<String, Gauge>();
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
