stankiewicz commented on code in PR #34135:
URL: https://github.com/apache/beam/pull/34135#discussion_r1979285978
##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -1763,7 +1819,7 @@ def get_beam_typehints_from_tableschema(schema):
schema = get_bq_tableschema(schema)
typehints = []
for field in schema.fields:
- name, field_type, mode = field.name, field.type.upper(), field.mode.upper()
+ name, field_type, mode = field.name, field_type.upper(), field.mode.upper()
Review Comment:
lets take fields = [ { name: foo1, type: bar1 }, { name: foo2, type: bar2 }]
expected name, field_type in first iteration are name = foo1, field_type=
BAR1.
I'm not sure if `name, field_type, mode = field.name, field_type.upper(),
field.mode.upper()` will produce that output.
forget about what I said - you touched interesting point! Why calling
upper() in string that is already uppercase causes an error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
