Strikerrx01 commented on code in PR #34135:
URL: https://github.com/apache/beam/pull/34135#discussion_r1979328418
##########
sdks/python/apache_beam/io/gcp/bigquery_tools_test.py:
##########
@@ -1044,6 +1168,46 @@ def
test_typehints_from_schema_with_repeated_struct(self):
self.assertEqual(typehints, expected_typehints)
+ # TODO(BEAM-XXXX): These tests are deprecated and will be removed.
Review Comment:
@stankiewicz Regarding the TODO comment - I added this to mark the duplicate
tests that were accidentally added in both `TestBigQueryWrapper` and
`TestBeamTypehintFromSchema` classes. I can remove these duplicate tests since
they're now properly placed in `TestBigQueryWrapper`. Would you prefer that
approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
