tvalentyn commented on code in PR #34225:
URL: https://github.com/apache/beam/pull/34225#discussion_r1988246888
##########
sdks/python/apache_beam/io/tfrecordio.py:
##########
@@ -57,7 +57,7 @@ def _default_crc32c_fn(value):
if not _default_crc32c_fn.fn:
_LOGGER.warning(
- 'Couldn\'t find python-snappy so the implementation of '
+ 'Couldn\'t find python-snappy (<0.7) so the implementation of '
Review Comment:
+0 (I don't think this is necessary.) I think requirements should be
controlled outside of code (e.g. via extras), if that is necessary.
if you decide to merge, you could write:
```suggestion
'Couldn\'t find python-snappy<0.7 so the implementation of '
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
