liferoad commented on code in PR #34225:
URL: https://github.com/apache/beam/pull/34225#discussion_r1988251827
##########
sdks/python/apache_beam/io/tfrecordio.py:
##########
@@ -57,7 +57,7 @@ def _default_crc32c_fn(value):
if not _default_crc32c_fn.fn:
_LOGGER.warning(
- 'Couldn\'t find python-snappy so the implementation of '
+ 'Couldn\'t find python-snappy (<0.7) so the implementation of '
Review Comment:
well, this one is tricky since snappy (>=0.7) completely removes `crc32c`.
Better call this out clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
