Abacn commented on code in PR #34394:
URL: https://github.com/apache/beam/pull/34394#discussion_r2010471432
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -72,6 +72,8 @@ public Schema configurationSchema() {
// readQuery
.addNullableField("partitionColumn", FieldType.STRING)
.addNullableField("partitions", FieldType.INT16)
+ .addNullableField("longLowerBound", FieldType.INT64)
Review Comment:
This only works for long. Currently there is builtin support for Long and
Datetime. I am thinking about if it would benefits from a more flexible
parameter design, e.g. pass in string and partition type names as SchemaIO
parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
