claudevdm commented on code in PR #34394:
URL: https://github.com/apache/beam/pull/34394#discussion_r2010728937
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -72,6 +72,8 @@ public Schema configurationSchema() {
// readQuery
.addNullableField("partitionColumn", FieldType.STRING)
.addNullableField("partitions", FieldType.INT16)
+ .addNullableField("longLowerBound", FieldType.INT64)
Review Comment:
I think keeping stricter types here simplifies things because read with
partitions only supports dates and integers, if we think there is a chance we
will add more partition types then a more flexible approach might be worth it?
If you feel strongly about this I can change this to the flexible approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
