damccorm commented on code in PR #34484:
URL: https://github.com/apache/beam/pull/34484#discussion_r2027430192
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -388,7 +388,8 @@ def create_stages(
translations.lift_combiners,
translations.expand_sdf,
translations.expand_gbk,
- translations.sink_flattens,
+ translations.fix_flatten_coders,
Review Comment:
I think this maybe doesn't work because fix_flatten_coders assumes that the
flattens will eventually be dealt with by sink_flattens. That may be what is
causing the failures?
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -388,7 +388,8 @@ def create_stages(
translations.lift_combiners,
translations.expand_sdf,
translations.expand_gbk,
- translations.sink_flattens,
+ translations.fix_flatten_coders,
+ # translations.sink_flattens,
Review Comment:
I think it would be better to try to fix the underlying issue. This has the
potential to introduce new encoding/decoding problems which it may be possible
to generally avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
