shunping commented on code in PR #34824:
URL: https://github.com/apache/beam/pull/34824#discussion_r2072427523


##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -1753,6 +1755,18 @@ def __hash__(self):
     return hash(type(self))
 
 
+class PaneInfoCoder(FastCoder):
+  def _create_impl(self):
+    return coder_impl.PaneInfoCoderImpl()
+
+  def is_deterministic(self):
+    # type: () -> bool
+    return True
+
+  def to_type_hint(self):
+    return windowed_value.PaneInfo
+

Review Comment:
   Do we need to override __eq__ and __hash__ as other coders here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to