Abacn commented on code in PR #34824:
URL: https://github.com/apache/beam/pull/34824#discussion_r2073679029
##########
sdks/python/apache_beam/coders/typecoders.py:
##########
@@ -92,6 +93,7 @@ def register_standard_coders(self, fallback_coder):
self._register_coder_internal(bytes, coders.BytesCoder)
self._register_coder_internal(bool, coders.BooleanCoder)
self._register_coder_internal(str, coders.StrUtf8Coder)
+ self._register_coder_internal(windowed_value.PaneInfo,
coders.PaneInfoCoder)
Review Comment:
> is there a disadvantage to doing it here
This introduces a breaking change such that windowed_value.PaneInfo has
changed default coder. This is not limited to ReShuffle but also user pipeline.
Since test results shows PaneInfoCoder is much more efficient than
FastPrimitiveCoder for PaneInfo, I am fine with the change, just need to know
this is another breaking change introduced in 2.65.0
If we keep this change I recommend to also mention this in
https://github.com/apache/beam/blob/master/CHANGES.md#breaking-changes-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
