dedocibula commented on code in PR #35042:
URL: https://github.com/apache/beam/pull/35042#discussion_r2120954833
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataDao.java:
##########
@@ -178,47 +179,57 @@ public List<String> findAllTableIndexes() {
*
* @return the earliest partition watermark which is not in a {@link
State#FINISHED} state.
*/
- public @Nullable Timestamp getUnfinishedMinWatermark() {
+ public @Nullable Timestamp getUnfinishedMinWatermark(Optional<Timestamp>
since) {
Review Comment:
Hmm how about getUnfinishedMinWatermarkFrom(Timestamp since). Just finding:
dao.getUnfinishedMinWatermarkFrom(Timestamp.MIN_VALUE);
more readable than
dao.getUnfinishedMinWatermark(Optional.empty());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
