changliiu commented on code in PR #35042:
URL: https://github.com/apache/beam/pull/35042#discussion_r2145527835
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/cache/NoOpWatermarkCache.java:
##########
@@ -35,6 +35,6 @@ public NoOpWatermarkCache(PartitionMetadataDao dao) {
@Override
public @Nullable Timestamp getUnfinishedMinWatermark() {
- return dao.getUnfinishedMinWatermark();
+ return dao.getUnfinishedMinWatermarkFrom(Timestamp.MIN_VALUE);
Review Comment:
we change the unfinished min watermark query with a filter. The filter will
only work if the async cache is used to update the cache every time the cached
value is updated.
By contrast, the NoOpWatermarkCache will not take advantage of this filter.
For the sake of readability, we adjust the function of query unfinished
watermark to `getUnfinishedMinWatermarkFrom`. And in NoOpWatermarkCache we give
the parameter as the min timestamp.
Please re-open or we can discuss offline if this doesn't answer your
question. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
