ahmedabu98 commented on code in PR #35017:
URL: https://github.com/apache/beam/pull/35017#discussion_r2129102478
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/FirestoreV1.java:
##########
@@ -1414,9 +1446,33 @@ private Builder(
super(clock, firestoreStatefulComponentFactory, rpcQosOptions);
}
+ /** Set the GCP project ID to be used by the Firestore client. */
+ public Builder setProjectId(@Nullable String projectId) {
+ this.projectId = projectId;
+ return this;
+ }
+
+ /** Set the Firestore database ID (e.g., "(default)"). */
+ public Builder setDatabaseId(@Nullable String databaseId) {
+ this.databaseId = databaseId;
+ return this;
+ }
+
+ @VisibleForTesting
+ public @Nullable String getProjectId() {
+ return this.projectId;
+ }
+
+ @VisibleForTesting
+ public @Nullable String getDatabaseId() {
+ return this.databaseId;
+ }
Review Comment:
Package private should still make it accessible to the test module
i.e. ` @Nullable String getProjectId` (without any explicit access
modifiers like "public" or "private")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
