claudevdm commented on code in PR #35234:
URL: https://github.com/apache/beam/pull/35234#discussion_r2139070201
##########
sdks/python/apache_beam/ml/inference/vllm_inference.py:
##########
@@ -114,28 +114,30 @@ def __init__(self, model_name: str, vllm_server_kwargs:
dict[str, str]):
self._server_started = False
self._server_process = None
self._server_port: int = -1
+ self._server_process_lock = threading.RLock()
Review Comment:
What happens when multiple threads try to start the server at the same time?
Should we use a cross process lock since multiple processes also share the
server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
