damccorm commented on PR #35216:
URL: https://github.com/apache/beam/pull/35216#issuecomment-2976869089

   > @damccorm – CI tests are currently failing due to a dependency conflict. 
Currently pymilvus requires protobuf version >=5.27.2 as specified in 
[pymilvus/pyproject.toml](https://github.com/milvus-io/pymilvus/blob/382c148aa4f5f45280b3aa170a83dddbc017e353/pyproject.toml#L26).
 Updating the major version for lower bound of protobuf causes conflict with 
existing beam requirements, as seen in the following error:
   > 
   > ```
   > ERROR: pip's dependency resolver does not currently take into account all 
the packages that are installed. This behaviour is the source of the following 
dependency conflicts.
   > grpcio-status 1.65.5 requires protobuf<6.0dev,>=5.26.1, but you have 
protobuf 4.25.8 which is incompatible.
   > pymilvus 2.5.11 requires grpcio<=1.67.1,>=1.49.1, but you have grpcio 
1.73.0 which is incompatible.
   > ```
   > 
   > This seems to mainly conflict with this comment in `sdks/python/setup.py`:
   > 
   > 
https://github.com/apache/beam/blob/9057cc29f3f3ac1464d0351628b8fa26339cca16/sdks/python/setup.py#L389
   > 
   > How is this supposed to be be handled moving forward?
   
   It looks to me like the issue is actually more specifically the grpcio 
version - 
https://github.com/apache/beam/blob/9057cc29f3f3ac1464d0351628b8fa26339cca16/sdks/python/setup.py#L371
   
   From the error you shared, `pymilvus 2.5.11 requires 
grpcio<=1.67.1,>=1.49.1, but you have grpcio 1.73.0 which is incompatible.`. 
Beam requires `grpcio>=1.67.0` when using python 3.12, so I'm guessing that is 
where we're seeing the issue. Are you using Python 3.12? If so, one temporary 
option would be to exclude Python 3.12 until pymilvus supports a higher grpcio 
version.
   
   It looks like they are planning to change that soon - 
https://github.com/milvus-io/pymilvus/blob/cbc825e8857b74ccaf7b873fd91e4e64c64270dc/pyproject.toml#L25
 - so we could also probably just pin to different versions of pymilvus for 
Python 3.12+ and Python <=3.11.
   
   I'm guessing that is where the grpcio-status conflict is coming from as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to