claudevdm commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150441490
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
What happens when the read times out here? Will the pipeline fail faster, or
will the specific read be retried? If it is retried, will we be able to recover
from a stream that has been cancelled (meaning the work is sent to a different
worker that references a different stream)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
