Abacn commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150872017
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
Previously it defaults to google.api_core.gapic_v1.method.DEFAULT, now
defaults to 1 h. Wouldn't it break legit use case of long running read
operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
