changliiu commented on code in PR #35258: URL: https://github.com/apache/beam/pull/35258#discussion_r2151097189
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/model/PartitionEventRecord.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.spanner.changestreams.model; + +import com.google.cloud.Timestamp; +import java.util.List; +import java.util.Objects; +import org.apache.avro.reflect.AvroEncode; +import org.apache.avro.reflect.Nullable; +import org.apache.beam.sdk.coders.DefaultCoder; +import org.apache.beam.sdk.extensions.avro.coders.AvroCoder; +import org.apache.beam.sdk.io.gcp.spanner.changestreams.encoder.TimestampEncoding; + +/** A partition event record describes key range changes for a change stream partition. */ +@SuppressWarnings("initialization.fields.uninitialized") // Avro requires the default constructor +@DefaultCoder(AvroCoder.class) +public class PartitionEventRecord implements ChangeStreamRecord { Review Comment: Although PartitionEventRecord doesn't affect the returned result, but I think it would be nice to add without too much engineer effort in terms of completeness. This PartitionEventRecord can update the watermark also. Please let me know if you have strong opinions. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
