johnjcasey commented on code in PR #35292:
URL: https://github.com/apache/beam/pull/35292#discussion_r2154634200


##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -877,7 +877,13 @@ static <K, V> void setupExternalBuilder(
 
         // We can expose dynamic read to external build when ReadFromKafkaDoFn 
is the default
         // implementation.
-        builder.setDynamicRead(false);
+        if (config.dynamicReadPollIntervalSeconds != null) {

Review Comment:
   sg, just get rid of the comment then good to go



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to