liferoad commented on code in PR #35292:
URL: https://github.com/apache/beam/pull/35292#discussion_r2153258788
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -877,7 +877,13 @@ static <K, V> void setupExternalBuilder(
// We can expose dynamic read to external build when ReadFromKafkaDoFn
is the default
// implementation.
- builder.setDynamicRead(false);
+ if (config.dynamicReadPollIntervalSeconds != null) {
Review Comment:
The `setupExternalBuilder` is for external transform, which is used in
cross-lang. And`dynamicReadPollIntervalSeconds` is only exposed to Python.
These should guarantee `ReadFromKafkaDoFn` is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
