damccorm commented on code in PR #35197: URL: https://github.com/apache/beam/pull/35197#discussion_r2158863302
########## sdks/python/apache_beam/transforms/enrichment_handlers/bigquery_storage_read.py: ########## @@ -0,0 +1,763 @@ +# -*- coding: utf-8 -*- +# Copyright 2024 Google LLC & Apache Software Foundation (Original License +# Header) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +BigQuery Enrichment Source Handler using the BigQuery Storage Read API Review Comment: Rather than having a whole new enrichment handler, if we want to expose storage read we should just make read mode a parameter to https://github.com/apache/beam/blob/da1768f18c0333d19a7b90f9cda072cbf1ea1f01/sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py#L55 (or really probably something like a `BigQueryReadOptions` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
