pandasanjay commented on code in PR #35197: URL: https://github.com/apache/beam/pull/35197#discussion_r2159536038
########## sdks/python/apache_beam/transforms/enrichment_handlers/bigquery_storage_read.py: ########## @@ -0,0 +1,763 @@ +# -*- coding: utf-8 -*- +# Copyright 2024 Google LLC & Apache Software Foundation (Original License +# Header) +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +BigQuery Enrichment Source Handler using the BigQuery Storage Read API Review Comment: That’s a great idea, @damccorm —I was actually thinking about this recently as well. Let me take a look and see what we can do. The last time I worked with BQ enrichment, I noticed a few missing features, so I ended up copying the code into our project and extending the BigQueryEnrichmentHandler. These enhancements have introduced some breaking changes: 1. Improved row restriction templating. 2. Previously, if fields = ['id'] and the corresponding parameter was null in the input, the entire record would be dropped. This behavior has now been addressed part of the PR. There are a few other enhancements as well. All of these extensions are available in the current PR, and you can find more details here: https://github.com/pandasanjay/beam-custom-implementation/blob/main/docs/bigquery_storage_enrichment_handler.md Are we okay with introducing these breaking changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
