shunping commented on code in PR #35243:
URL: https://github.com/apache/beam/pull/35243#discussion_r2161408122
##########
sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py:
##########
@@ -255,10 +253,6 @@ def test_xlang_jdbc_write_read(self, database):
classpath=config['classpath'],
))
- # Register MillisInstant logical type to override the mapping from
Timestamp
- # originally handled by MicrosInstant.
- LogicalType.register_logical_type(MillisInstant)
Review Comment:
Hmmm, removing that line is the main purpose of this PR. Let's revert the PR
for now and I will take a look at that failed test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
