akashorabek commented on code in PR #35243:
URL: https://github.com/apache/beam/pull/35243#discussion_r2161523545
##########
sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py:
##########
@@ -255,10 +253,6 @@ def test_xlang_jdbc_write_read(self, database):
classpath=config['classpath'],
))
- # Register MillisInstant logical type to override the mapping from
Timestamp
- # originally handled by MicrosInstant.
- LogicalType.register_logical_type(MillisInstant)
Review Comment:
I created a [PR](https://github.com/apache/beam/pull/35396) that reverts
this one and [#35191](https://github.com/apache/beam/pull/35191), which also
contributed to the failures of PostCommit Python XLang GCP Direct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
