shunping commented on code in PR #35426:
URL: https://github.com/apache/beam/pull/35426#discussion_r2173595780
##########
sdks/python/apache_beam/typehints/schema_registry.py:
##########
@@ -40,7 +40,7 @@ def generate_new_id(self):
"schemas.")
def add(self, typing, schema):
- if not schema.id:
+ if schema.id:
Review Comment:
I don't know why we change this line in
https://github.com/apache/beam/pull/28169 to disable the look up of schema
registry.
Let's see if this breaks anythong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
