shunping commented on code in PR #35426:
URL: https://github.com/apache/beam/pull/35426#discussion_r2173748171
##########
sdks/python/apache_beam/typehints/schema_registry.py:
##########
@@ -40,7 +40,7 @@ def generate_new_id(self):
"schemas.")
def add(self, typing, schema):
- if not schema.id:
+ if schema.id:
Review Comment:
@Abacn, do you know which workflow covers this test?
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProviderTest.java
##########
sdks/python/apache_beam/typehints/schema_registry.py:
##########
@@ -40,7 +40,7 @@ def generate_new_id(self):
"schemas.")
def add(self, typing, schema):
- if not schema.id:
+ if schema.id:
Review Comment:
@Abacn, do you know which test workflow covers this test?
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProviderTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
