scwhittle commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2175469035
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ExecutionStateSampler.java:
##########
@@ -65,6 +68,7 @@ public class ExecutionStateSampler {
private static final Logger LOG =
LoggerFactory.getLogger(ExecutionStateSampler.class);
private static final int DEFAULT_SAMPLING_PERIOD_MS = 200;
private static final long MAX_LULL_TIME_MS = TimeUnit.MINUTES.toMillis(5);
+ private static final long MIN_LULL_TIME_MS_FOR_RESTART =
TimeUnit.MINUTES.toMillis(10);
Review Comment:
We have pipelines with second/multiple second latency. I think that having
a limit higher than the cost of restarting the JVM doesn't make that much sense
but 10 minutes seems higher than that. If the flag is minutes, then 1 minute
woudl be the lowest possible to set and perhaps that is desirable for some
users and I don't think we should bother trying to prevent against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
