scwhittle commented on code in PR #35120:
URL: https://github.com/apache/beam/pull/35120#discussion_r2175473203
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -427,4 +427,16 @@ public Duration create(PipelineOptions options) {
: Duration.ofMinutes(1);
}
}
+
+ /**
+ * The time limit (in minute) that an SDK worker allows for a PTransform
operation before
+ * signaling the runner harness to restart the SDK worker.
+ */
+ @Description(
+ "The time limit (minute) that an SDK worker allows for a PTransform
operation "
+ + "before signaling the runner harness to restart the SDK worker.")
+ @NonNegative
+ int getPtransformTimeoutDuration();
Review Comment:
Please put the units in the option name then, ie
getElementProcessingTimeoutMinutes
Otherwise I would expect it to be seconds but on command line it is unclear:
`--elementProcessingTimeout=X`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
