twosom commented on code in PR #35316:
URL: https://github.com/apache/beam/pull/35316#discussion_r2195257266
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/util/TimerUtils.java:
##########
@@ -35,10 +167,128 @@ public static <W extends BoundedWindow> void
dropExpiredTimers(
timer
.getTimestamp()
.plus(windowingStrategy.getAllowedLateness())
-
.isBefore(sparkTimerInternals.currentInputWatermarkTime()))
+ .isBefore(
+
timer.getDomain().equals(TimeDomain.PROCESSING_TIME)
+ ? sparkTimerInternals.currentProcessingTime()
Review Comment:
@damccorm
You're absolutely right! I've added `TimerUtils.triggerExpiredTimers` to
fire expired processing time timers before clearing them. This ensures we don't
lose any timer callbacks that should have been executed.
Please take a look at the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
