damccorm commented on code in PR #35952:
URL: https://github.com/apache/beam/pull/35952#discussion_r2304978111
##########
sdks/python/apache_beam/yaml/json_utils.py:
##########
@@ -287,8 +287,9 @@ def row_to_json(beam_type: schema_pb2.FieldType) ->
Callable[[Any], Any]:
for field in beam_type.row_type.schema.fields
}
return lambda row: {
- name: convert(getattr(row, name))
+ name: converted
for (name, convert) in converters.items()
+ if (converted := convert(getattr(row, name, None))) is not None
Review Comment:
Ok. I think this is fine - arguably both should error, but I think making
all fields nullable is ok.
Eventually it might be good to add a `optional: False` field so that we can
validate null fields as errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
