shunping commented on code in PR #35991:
URL: https://github.com/apache/beam/pull/35991#discussion_r2307534611
##########
sdks/go/pkg/beam/runners/prism/internal/environments.go:
##########
@@ -259,7 +259,7 @@ func dockerEnvironment(ctx context.Context, logger
*slog.Logger, dp *pipepb.Dock
defer rc.Close()
var buf bytes.Buffer
stdcopy.StdCopy(&buf, &buf, rc)
- logger.Info("container being killed",
slog.Any("cause", context.Cause(ctx)), slog.Any("containerLog", buf))
+ logger.Info("container being killed",
slog.Any("cause", context.Cause(ctx)), slog.String("containerLog",
buf.String()))
Review Comment:
Here we want to print out the text in the buffer rather than the byte array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
