shunping commented on code in PR #35991:
URL: https://github.com/apache/beam/pull/35991#discussion_r2307649090
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -95,7 +96,7 @@ func RunPipeline(j *jobservices.Job) {
j.SendMsg("pipeline completed " + j.String())
j.SendMsg("terminating " + j.String())
- j.Done()
+ j.PendingDone = true
Review Comment:
Done. But I think it is not likely to have a race condition here, because
the read part is called inside a defer in the same function (RunPipeline).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
