kennknowles commented on PR #34902: URL: https://github.com/apache/beam/pull/34902#issuecomment-3286221904
I think Radek you have the most context, and can critique the details where I have missed something. Especially in FnApiDoFnRunner I see a couple spots where I think I must have gotten impatient - wherever I decompose a WindowedValue and then it gets put back together, we will lose metadata (once it is introduced). I realize I also need some end-user tests of the OutputBuilder. It is very _very_ thoroughly tested by how it is used internal to the SDK but there are no examples of use in a DoFn in an actual pipeline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
