lostluck commented on PR #36191: URL: https://github.com/apache/beam/pull/36191#issuecomment-3308874192
> Ok. I ran `go generate` under the following affected packages/folders: > > ``` > sdks/go/pkg/beam > sdks/go/pkg/beam/testing/passert > sdks/go/pkg/beam/core/runtime/exec/optimized > sdks/go/pkg/beam/x/debug > sdks/go/pkg/beam/runners/vet/testpipeline > ``` > > However, it seems there more diffs than I would expected. Now I am not sure if I did it correctly ... The code generator has been largely deprecated for the last 3 years, in favour of generic registration package (...beam/register), so it's most likely those diffs are due to not having been updated since then. It's definitely a thing where fixing the generator is better than manually fixing the diffs. Taking a look... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
