lostluck commented on code in PR #36191:
URL: https://github.com/apache/beam/pull/36191#discussion_r2360583537
##########
sdks/go/pkg/beam/core/runtime/exec/pardo.go:
##########
@@ -474,7 +474,7 @@ func (n *ParDo) processTimer(timerFamilyID string,
singleWindow []typex.Window,
err = postErr
}
}()
- if err := n.preInvoke(n.ctx, singleWindow, tmap.HoldTimestamp); err !=
nil {
+ if err := n.preInvoke(n.ctx, typex.PaneInfo{}, singleWindow,
tmap.HoldTimestamp); err != nil {
Review Comment:
While a timer invocation doesn't technically have a pane, it should have the
NoFiringPane instead of the zero value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
