tvalentyn commented on code in PR #36316:
URL: https://github.com/apache/beam/pull/36316#discussion_r2395276592
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,15 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
+ """For internal use. Appends a version tag to the coder key in the pipeline
+ proto. Some runners (e.g. DataflowRunner) use coder key/id to verify if a
+ pipeline is update compatibile. If the implementation of a coder changed
+ in an update incompatible way a version tag can be added to fail compat
Review Comment:
```suggestion
in an update incompatible way, a version tag can be added to fail
```
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,15 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
+ """For internal use. Appends a version tag to the coder key in the pipeline
+ proto. Some runners (e.g. DataflowRunner) use coder key/id to verify if a
+ pipeline is update compatibile. If the implementation of a coder changed
+ in an update incompatible way a version tag can be added to fail compat
+ checks.
Review Comment:
```suggestion
compatibility checks.
```
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,15 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
+ """For internal use. Appends a version tag to the coder key in the pipeline
+ proto. Some runners (e.g. DataflowRunner) use coder key/id to verify if a
+ pipeline is update compatibile. If the implementation of a coder changed
Review Comment:
```suggestion
pipeline is update compatible. If the implementation of a coder changed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
