tvalentyn commented on code in PR #36316:
URL: https://github.com/apache/beam/pull/36316#discussion_r2389518877
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,13 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
+ """Appends a version tag to the coder key in the pipeline proto. Versioning
Review Comment:
would this be a better wording or i am misunderstanding the usecase (e.g. a
mere presense of this string signals something)
```suggestion
"""A version tag to append to the coder key in the pipeline proto. A
change in version
```
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,13 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
Review Comment:
> signals to the runner that a pipeline implementation has changed and is
trying to understand possible usecases here. what changes do we mean? coder
implementation changed? if so: will this be applicable for user-defined custom
coders? Say, I am writing my own coder, do i need to understand how to use this
method and implement it. or this is only for beam internal coder
implementations only?
> not update compatible with different versions.
which usecases you have in mind here: .. different version of the pipeline,
or different versions of beam SDK that launches the same pipeline, or both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
