kristynsmith commented on PR #35904: URL: https://github.com/apache/beam/pull/35904#issuecomment-3383029259
> @kristynsmith can you please check failing tests i was able to fix the test but only by adding an import in cloudpickle.py. i know it's not ideal but i wasn't able to figure out how to fix it otherwise. in make_function_from_identifier, we were trying to have get_code_from_identifier be passed in as a parameter but _stable_identifier_function_reduce has to return all of the parameters needed for make_function_from_identifier and there's no way to get get_code_from_identifier without importing it. so to simplify it i removed get_code_from_identifier as a parameter for make_function_from_identifier and had the reference to it in make_function_from_identifier come from the import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
